Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax googleauth versions #333

Merged
merged 4 commits into from
Oct 18, 2018
Merged

Relax googleauth versions #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4ef891
Relax googleauth versions
stefanmb Sep 19, 2018
4913c8c
Update kubernetes-deploy.gemspec
stefanmb Sep 20, 2018
680036a
Typo
stefanmb Sep 20, 2018
1f3d821
Update tests
stefanmb Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kubernetes-deploy.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '>= 2.3.0'
spec.add_dependency "activesupport", ">= 5.0"
spec.add_dependency "kubeclient", "~> 3.0"
spec.add_dependency "googleauth", "= 0.6.2" # https://github.com/google/google-auth-library-ruby/issues/153
spec.add_dependency "googleauth", "~> 0.6.6" # https://github.com/google/google-auth-library-ruby/issues/153
spec.add_dependency "ejson", "~> 1.0"
spec.add_dependency "colorize", "~> 0.8"
spec.add_dependency "statsd-instrument", "~> 2.2"
Expand Down
4 changes: 2 additions & 2 deletions test/unit/kubernetes-deploy/google_friendly_config_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def teardown
def test_auth_use_default_gcp_success
config = KubernetesDeploy::KubeclientBuilder::GoogleFriendlyConfig.new(kubeconfig, "")

stub_request(:post, 'https://www.googleapis.com/oauth2/v4/token')
stub_request(:post, 'https://oauth2.googleapis.com/token')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a legitimate change introduced by googleapis/google-auth-library-ruby#147.

Note that there isn't much in the way of docs in that PR, and the old version we used (0.6.2) has no tag associated with it.

.to_return(
headers: { 'Content-Type' => 'application/json' },
body: {
Expand All @@ -33,7 +33,7 @@ def test_auth_use_default_gcp_success
def test_auth_use_default_gcp_failure
config = KubernetesDeploy::KubeclientBuilder::GoogleFriendlyConfig.new(kubeconfig, "")

stub_request(:post, 'https://www.googleapis.com/oauth2/v4/token')
stub_request(:post, 'https://oauth2.googleapis.com/token')
.to_return(
headers: { 'Content-Type' => 'application/json' },
body: '',
Expand Down