Support test clusters other than minikube #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturn
approved these changes
Oct 25, 2018
| nodes = kubeclient.get_nodes | ||
| return 1 if nodes.one? | ||
| nodes.count do |node| | ||
| !node.metadata.labels.to_h.keys.include?(:"node-role.kubernetes.io/master") |
There was a problem hiding this comment.
dind gives you a multi node setup?
There was a problem hiding this comment.
Yep! Two nodes + master by default. Here's the repo for it FYI: https://github.com/kubernetes-sigs/kubeadm-dind-cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to run the tests against a docker-in-docker cluster for example (which I've been using lately). To do that, you create a
.local-contextfile (which is git ignored) containing the name of the context you want to use. This is similar to what we did for Cloud Portal.@Shopify/cloudx for review