Predeploy roles before RoleBindings #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If role bindings rely on a role, deployment fails as role is not available. Fixed by predeploying roles.
dturn
suggested changes
Nov 26, 2018
|
Fixed the rubocop error. |
dturn
approved these changes
Nov 26, 2018
KnVerey
approved these changes
Nov 27, 2018
| @@ -89,6 +89,10 @@ def assert_all_service_accounts_up | |||
| assert_service_account_present("build-robot") | |||
| end | |||
|
|
|||
| def assert_all_roles_up | |||
There was a problem hiding this comment.
Can you please call this from assert_all_up (L9 of this file) too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoleBindings were added to predeploy in #354. If role bindings rely on a role, deployment fails as role is not available. Fixed by predeploying roles.