-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add k8s v13, remove v9 #409
Conversation
I'll close out my version of this https://github.com/Shopify/kubernetes-deploy/pull/405/files. But there is more work besides making CI pass, we'll also need to remove the references to 1.9 in the code and updates the read me. See #341 as an example |
Thanks Danny for the example PR. |
we will have to update the changelog when we release the update to the gem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I don't think we need to cut a release at this time as an fyi.
Fair enough, we could have an changelog update with an unreleased note to the latest version |
sure, will not give a release at the moment. |
What are you trying to accomplish with this PR?
add k8s v1.13 to pipeline
How is this accomplished?
update .buildkite.yml
What could go wrong?
...