Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add k8s v13, remove v9 #409

Merged
merged 4 commits into from
Jan 9, 2019
Merged

add k8s v13, remove v9 #409

merged 4 commits into from
Jan 9, 2019

Conversation

jessie-JNing
Copy link
Contributor

@jessie-JNing jessie-JNing commented Jan 4, 2019

What are you trying to accomplish with this PR?
add k8s v1.13 to pipeline

How is this accomplished?
update .buildkite.yml

What could go wrong?
...

@dturn
Copy link
Contributor

dturn commented Jan 4, 2019

I'll close out my version of this https://github.com/Shopify/kubernetes-deploy/pull/405/files. But there is more work besides making CI pass, we'll also need to remove the references to 1.9 in the code and updates the read me. See #341 as an example

@dturn dturn mentioned this pull request Jan 4, 2019
@jessie-JNing
Copy link
Contributor Author

I'll close out my version of this https://github.com/Shopify/kubernetes-deploy/pull/405/files. But there is more work besides making CI pass, we'll also need to remove the references to 1.9 in the code and updates the read me. See #341 as an example

Thanks Danny for the example PR.
I'll clean 1.9 related code after finishing the change in k8s-ci

@karanthukral
Copy link
Contributor

we will have to update the changelog when we release the update to the gem

Copy link
Contributor

@dturn dturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't think we need to cut a release at this time as an fyi.

@karanthukral
Copy link
Contributor

Looks good. I don't think we need to cut a release at this time as an fyi.

Fair enough, we could have an changelog update with an unreleased note to the latest version

@jessie-JNing
Copy link
Contributor Author

Looks good. I don't think we need to cut a release at this time as an fyi.

Fair enough, we could have an changelog update with an unreleased note to the latest version

sure, will not give a release at the moment.
I update the changelog though, please check this commit

@jessie-JNing jessie-JNing merged commit ee75d48 into master Jan 9, 2019
@jessie-JNing jessie-JNing deleted the k8sv13 branch January 9, 2019 20:21
@jessie-JNing jessie-JNing temporarily deployed to rubygems January 10, 2019 17:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants