prevent invalid const errors from lowercase resource kind #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnVerey
approved these changes
Jan 16, 2019
| @@ -288,6 +288,17 @@ def test_disappeared_is_false_if_resource_has_been_deployed_and_we_get_a_server_ | |||
| refute_predicate(dummy, :disappeared?) | |||
| end | |||
|
|
|||
| def test_custom_resource_kind | |||
There was a problem hiding this comment.
Can you make this name more descriptive and/or add an assert_nothing_raised and/or assert that build returned an instance of the expected class? I'm thinking it won't be very obvious in the future what this test is covering / what the bug was.
| namespace: 'test', | ||
| context: 'test', | ||
| definition: definition, | ||
| logger: ::Logger.new($stderr), |
There was a problem hiding this comment.
Not that it makes any difference here, but FYI there's a logger accessor all tests can use.
dturn
approved these changes
Jan 17, 2019
dwradcliffe
changed the title
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Fix errors that occur if one attempts to deploy a resource that has a kind with a lowercase first letter. This is not the case for any of the standard k8s kinds, but custom resources may use lowercase kinds.
How is this accomplished?
Capitalize the string before checking for a const. This seemed like the simplest change that wouldn't impact the existing logic.This would also allow these resource types to have custom resources classes added, in the capitalized form.
Rescue the NameError and fallback to the generic class. This is safer than changing the string and catches any other edge cases we haven't thought about.
What could go wrong?
I can't really think of anything.