Add support for NetworkPolicies #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1koo
force-pushed
the
dont_nag_on_netpols
branch
2 times, most recently
from
59e4703
to
3a48ee0
Compare
dturn
approved these changes
Feb 22, 2019
n1koo
force-pushed
the
dont_nag_on_netpols
branch
from
3a48ee0
to
06a9bfa
Compare
|
Yeah that makes sense, changed |
KnVerey
reviewed
Feb 26, 2019
| @@ -1080,6 +1081,24 @@ def test_not_apply_resource_can_be_pruned | |||
| ]) | |||
| end | |||
|
|
|||
| def test_network_policies_are_deployed_first | |||
| assert_deploy_success(deploy_fixtures("network-policy")) | |||
There was a problem hiding this comment.
Instead of creating a separate fixture set with just this in it, on this line you can do deploy_fixtures('hello-cloud', subset: ['network_policy.yml'])
| "NetworkPolicy/allow-all-network-policy", | ||
| ], in_order: true) | ||
|
|
||
| netpols = networking_v1_kubeclient.get_network_policies(namespace: @namespace) |
There was a problem hiding this comment.
Instead of using kubeclient here, please augment the HelloCloud FixtureSet as described in our Readme:
Add the a basic example of the type to the hello-cloud fixture set and appropriate assertions to
#assert_all_upinhello_cloud.rb. This will get you coverage in several existing tests, such astest_full_hello_cloud_set_deploy_succeeds.
There was a problem hiding this comment.
Oh right missed that, sorry. Updated now
n1koo
force-pushed
the
dont_nag_on_netpols
branch
2 times, most recently
from
9588e85
to
ec887ea
Compare
dturn
reviewed
Feb 27, 2019
n1koo
force-pushed
the
dont_nag_on_netpols
branch
from
ec887ea
to
ec161b0
Compare
timothysmith0609
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Add support for
NetworkPolicyso that deploys dont nag about itHow is this accomplished?
Add resource type, copypaste things
What could go wrong?
I added support for pruning too because thats the correct way to do it, but might suprise people that do NetworkPolicies outside of deploys. Hopefully nobody does such a thing :)