Ruby 2.4 #536
Merged
Ruby 2.4 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnVerey
reviewed
Aug 20, 2019
KnVerey
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
I suggest we merge your conditional dependency solution first and release a patch version that way so the person who opened the bug has a version to work with. Then merge this as part of the Krane release or in the next minor version, at your discretion. Either way the change set lgtm.
jessie-JNing
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
End our support of Ruby 2.3 since Ruby 2.3 is no longer supported.
How is this accomplished?
Bump some things.
What could go wrong?
There isn't anything that requires 2.4, though there appears to be some gem version fun. We could since the burden to support 2.3 is trivial today we could keep supporting. However, I'm of the belief that we shouldn't tie ourselves to unsupported versions.