Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable deploying global resources by default #567

Merged
merged 9 commits into from
Oct 8, 2019
Merged

Disable deploying global resources by default #567

merged 9 commits into from
Oct 8, 2019

Commits on Oct 8, 2019

  1. Limit this PR to just disabling global deploys

    @dturn
    dturn committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    7e0f898 View commit details
    Browse the repository at this point in the history

  2. PVCs are failing to be created, try requesting smaller amounts of sto… 

    …rage
    @dturn
    dturn committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    886696b View commit details
    Browse the repository at this point in the history

  3. Ensure Krane::DeployTask can't deploy globals

    @dturn
    dturn committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    64d7813 View commit details
    Browse the repository at this point in the history

  4. Set PVs count to match parallelism

    @dturn
    dturn committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    5b34666 View commit details
    Browse the repository at this point in the history

  5. PR feedback

    @dturn
    dturn committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    2c1d97c View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-Authored-By: Katrina Verey <katrina.verey@shopify.com>
    @dturn @KnVerey
    dturn and KnVerey committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    8f0bd78 View commit details
    Browse the repository at this point in the history

  7. Parse output from wide. Note this is a fixed width format with missin… 

    …g values in some columns so relying on whitespace as a delimiter isn't sufficent
    @dturn
    dturn committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    39b72cc View commit details
    Browse the repository at this point in the history

  8. Add more tests

    @dturn
    dturn committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    81f4b69 View commit details
    Browse the repository at this point in the history

  9. Test fix up

    @dturn
    dturn committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    bcfd180 View commit details
    Browse the repository at this point in the history