Update the gemspec for Krane 1.0 #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas
reviewed
Nov 15, 2019
| spec.description = spec.summary | ||
| spec.homepage = "https://github.com/Shopify/kubernetes-deploy" | ||
| spec.homepage = "https://github.com/Shopify/krane" |
There was a problem hiding this comment.
Just to confirm, after the release are we going to rename the kubernetes-deploy to krane but are going to keep kubernetes-deploy repo around just with a README pointing to krane repo?
There was a problem hiding this comment.
We're going to rename the repo which should cause github to automatically redirect people. We'll also make sure the top of the readme mentions the rename and points to the migration guide
|
Can/do we document the yanking process anywhere? We've had a few releases go out that should be yanked (0.31.0 most recently) but I have no clue how to do this |
We don't. And as far as I know we don't have any automation around it either. |
dturn
changed the title
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
One of the last steps for releasing Krane 1.0.0 is updating the gemspec.
How is this accomplished?
Update the gemspec and use the existing description from https://rubygems.org/gems/krane
There is no rubygem rename ability, its just create a new one: https://help.rubygems.org/discussions/questions/104-how-should-i-handle-the-rename-of-a-gem
Shipit will automatically figure out the new gemspec.
What could go wrong?
Not much, worst case we quickly yank 1.0.0 while we fix the issue and create it again.