Exclude stderr from parsing on decryption success #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirceu
approved these changes
Nov 28, 2019
RyanBrushett
approved these changes
Nov 28, 2019
dturn
approved these changes
Nov 29, 2019
KnVerey
force-pushed
the
ejson_stdout
branch
from
cf8b4b3
to
f4d61b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Fixes #643. The underlying problem seems to be that we're reading stdout and stderr together. There are cases when successful ejson decryption returns both a warning (on stderr) and the result (on stdout), so unsurprisingly the combination of the two cannot be parsed. The reason we were doing this is because older versions of ejson printed many (all?) errors to stdout. Shopify/ejson#44 fixed this in version 1.2, but I'd prefer to continue supporting ejson 1.0, to avoid subjecting ruby consumers to dependency conflicts.
How is this accomplished?
Read stdout and stderr separately, but if decryption failed, manually check stdout for the error message to accommodate older ejson versions.
What could go wrong?
If ever ejson exits non-zero yet prints something decrypted to either stream, we'll also print it. This would not be new, however, and I've never heard a report of it happening.