Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with comma seperated binding example #664

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

justinsoong
Copy link

What are you trying to accomplish with this PR?
I think example for comma separated bindings, dropped the comma in one of the changes, bringing it back into the readme example

How is this accomplished?
readme change

What could go wrong?
Low risk, readme change

@ghost ghost added the cla-needed label Jan 13, 2020
@dturn
Copy link
Contributor

dturn commented Jan 13, 2020

@justinsoong Thanks for the PR. Can you please sign the CLA when you get a chance

@dturn dturn mentioned this pull request Jan 13, 2020
@justinsoong
Copy link
Author

@dturn done

1 similar comment
@justinsoong
Copy link
Author

@dturn done

@dturn dturn merged commit 3713cef into Shopify:master Jan 16, 2020
@dturn dturn temporarily deployed to rubygems January 22, 2020 19:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants