Deploy CustomResources after dependencies #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CustomResources are quite likey to depend on things like Secrets, RBAC resources or even PVCs. This change ensures these things are deployed prior to CustomResources so that they're available before blocking on monitoring the CustomResources for success. Fixes Shopify#670
|
Could someone please paste the test failure? |
|
Tests passed, it shows failure, because of #506 |
|
@dturn Might this be included in this week's release? |
Yes |
timothysmith0609
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
CustomResources are quite likely to depend on things like Secrets, RBAC resources or even PVCs. They should be available before blocking on monitoring the CustomResources for success.
Fixes #670
How is this accomplished?
This change ensures that CustomResources are pre-deployed after the other pre-deployed resource types.
What could go wrong?
WW3?