Drop Ruby 2.4, Add Ruby 2.6, Add k8s 1.17 #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturn
changed the title
dturn
force-pushed
the
ruby-2-7
branch
2 times, most recently
from
663c9cd
to
53c7044
Compare
ghost
added
the
KnVerey
reviewed
Feb 14, 2020
| env: | ||
| LOGGING_LEVEL: "4" | ||
| KUBERNETES_VERSION: v1.17-latest | ||
| RUBY_VERSION: "2.6" |
There was a problem hiding this comment.
How does this work? Isn't the container still circleci/ruby:2.5.7-node-browsers?
There was a problem hiding this comment.
dirceu
approved these changes
Feb 18, 2020
KnVerey
approved these changes
Feb 19, 2020
KnVerey
approved these changes
Feb 25, 2020
MrMarvin
added a commit
that referenced
this pull request
Mar 24, 2020
KnVerey
pushed a commit
that referenced
this pull request
Apr 13, 2020
* Drop ruby 2.4 and test using 2.6. * Smaller container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Add tests for K8s 1.17
Add tests for Ruby 2.6
Ruby 2.4 is EOL 3/31 might as well drop it 6 weeks early as long as I'm in this code.
How is this accomplished?
Update our pipeline file
What could go wrong?
Upset people who were still using 2.4. Though it's possible we don't cut a release before the 3/31 EoL date.
Sadly ruby 2.7 fails due to kuebclient ManageIQ/kubeclient#432