Version 1.0.0.pre.2 #731
Merged
Version 1.0.0.pre.2 #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanBrushett
force-pushed
the
relax-thor-version-requirement
branch
from
8fe356f
to
8e14080
Compare
dturn
approved these changes
Jul 21, 2020
|
I think you need to rename |
RyanBrushett
force-pushed
the
relax-thor-version-requirement
branch
5 times, most recently
from
0ac1f4d
to
ea8f5f2
Compare
- Release Version 1.0.0.pre.2 - Relax thor version in k8s-deploy gemspec - Relax googleauth restriction to ~> 0.9 - Pin K8s 1.16 CI to 1.16.12
RyanBrushett
force-pushed
the
relax-thor-version-requirement
branch
from
ea8f5f2
to
e2704a6
Compare
RyanBrushett
commented
Jul 27, 2020
| @@ -25,14 +25,14 @@ Gem::Specification.new do |spec| | |||
| spec.required_ruby_version = '>= 2.4.0' | |||
| spec.add_dependency("activesupport", ">= 5.0") | |||
| spec.add_dependency("kubeclient", "~> 4.3") | |||
| spec.add_dependency("googleauth", "~> 0.8.0") | |||
| spec.add_dependency("googleauth", "~> 0.8") | |||
There was a problem hiding this comment.
@dirceu I made a slight adjustment to match the googleauth dependency restriction with Krane's latest. You still 👍 ?
|
The only failure is on the linter and it's angry about the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
How is this accomplished?
>= 0.20and< 2.0, seemed like a sensible enough range. Make sense?