Evaluate progress condition after progress deadline seconds have passed #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -155,6 +155,7 @@ def rollout_annotation_err_msg | |||
|
|
|||
| def deploy_failing_to_progress? | |||
| return false unless progress_condition.present? | |||
| return false if deploy_started? && Time.now.utc - @deploy_started_at < progress_deadline | |||
There was a problem hiding this comment.
Worth a comment here, since the deploy is indeed failing to progress, we're just ignoring that for now :)
timothysmith0609
approved these changes
Nov 19, 2020
dturn
approved these changes
Nov 19, 2020
Closed
gigr
force-pushed
the
fast-fail-progress-deadline
branch
from
5bb8a48
to
aaa2486
Compare
gigr
force-pushed
the
fast-fail-progress-deadline
branch
from
aaa2486
to
e58c95d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change checks for the progress condition of a k8s deployment type after the progress deadline seconds have passed.
ie. when a deployment has been marked as failed to progress, we will wait for at least PDS seconds after a deploy/retry to mark it failed, instead of failing it right away
Note this assumes that
@deploy_started_atis reset during retries as the DeployTask creates a new instance of resource_deployer each time.cc @Shopify/pipeline