Only call Oj.mimic_JSON when in a CLI run

[casperisfine]

Context

We have a bunch of tests in our CI suite that require krane to test a few deploy stuffs. The problem is that requiring krane calls Oj.mimic_JSON which cause various issues to us.

Change

I think krane should only patch JSON when it is ran as CLI, as it has better control of what's running. When used as a library, that's not a good idea to patch core classes like this.

NB: my knowledge of crane and Thor is very limited, so this PR might be totally incorrect.

cc @paracycle @Shopify/test-infra

[casperisfine]

@paracycle all good points. I've updated the PR.

[douglas]

This looks good for me from what I remember working in Krane long time ago, but I defer to @dturn since I may be missing some context.

[dturn]

Oj.mimic_JSON brought a noticeable perf improvement (on the order of seconds) since this gem does a ton json processing. I'm ok with only including it in the CLI but please restore the lib/krane/oj.rb file.

[casperisfine]

but please restore the lib/krane/oj.rb file

I don't understand. I simply moved it's content inside krane/cli.rb. I'm fine restoring it and requiring it from krane/cli.rb but I don't really see the point.

[dturn]

but I don't really see the point.

Its a minor thing but, I think its better code organization, it also makes it a one liner to restore the behavior for people using Krane as a library.

[casperisfine]

but please restore the lib/krane/oj.rb file

Done.