Drop support for Ruby 2.5 as its close to EOL #782
Conversation
karanthukral
force-pushed
the
karan/drop-ruby-2-5
branch
from
68afdab
to
031dd7f
Compare
|
Shopify's style guide prefers allow-list/deny-list vs. white-list/black-list. |
karanthukral
force-pushed
the
karan/drop-ruby-2-5
branch
from
68e40b4
to
9818d90
Compare
| command: bin/ci | ||
| agents: | ||
| queue: k8s-ci | ||
| env: | ||
| LOGGING_LEVEL: "4" | ||
| KUBERNETES_VERSION: v1.19-latest | ||
| RUBY_VERSION: "2.7" |
There was a problem hiding this comment.
👍 (Assuming the idea is to test each version of ruby w/o building an entire matrix)
There was a problem hiding this comment.
yup! 2.6 default and then 2.7 and 3 on single k8s versions
dev.yml
Outdated
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| name: krane | |||
| up: | |||
| - ruby: 2.5.7 # Matches gemspec | |||
| - ruby: 3.0.0 # Matches gemspec | |||
There was a problem hiding this comment.
yes.. was using it for testing. Will set it to 2.6.6
karanthukral
force-pushed
the
karan/drop-ruby-2-5
branch
from
e5da973
to
ec09ca3
Compare
| kubectl.expects(:run).with { |*_args, **kwargs| kwargs[:output_is_sensitive] == true }.returns([ | ||
| "Some Raw Output", | ||
| "Error from kubectl: something went wrong and by the way here's your secret: S3CR3T", | ||
| stub(success?: false), | ||
| ]) | ||
| kubectl.expects(:run) |
There was a problem hiding this comment.
That's strange that this changed just from the Ruby version :/ I would have that it specific to Mocha. Regardless, I think it's ok for now, though I'm not a huge fan of introducing so much static info into the stub :(
There was a problem hiding this comment.
Ruby 2.7 deprecated some stuff with keyword args I haven't fully read up on it https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/ but maybe this smells like it could be related.
What are you trying to accomplish with this PR?
How is this accomplished?
What could go wrong?