Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce gem size by excluding screenshots #817

Merged
merged 2 commits into from
May 5, 2021
Merged

Reduce gem size by excluding screenshots #817

merged 2 commits into from
May 5, 2021

Conversation

etiennebarrie
Copy link
Member

What are you trying to accomplish with this PR?

Reduce gem size.

How is this accomplished?

Removing the README screenshots from the release.

$ rake build
$ du -h pkg/*                                                                                    
1.1M	pkg/krane-2.1.8.gem
 88K	pkg/krane-2.1.8.pre.dev.gem

What could go wrong?

Not much.

@etiennebarrie etiennebarrie requested a review from a team as a code owner April 16, 2021 15:35
@timothysmith0609
Copy link
Contributor

Not sure why CI is failing all of a sudden :/

@timothysmith0609 timothysmith0609 merged commit b20e1c5 into master May 5, 2021
@timothysmith0609 timothysmith0609 deleted the reduce-gem-size branch May 5, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysmith0609 timothysmith0609 timothysmith0609 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etiennebarrie @timothysmith0609