don't use uniq by kind for prunable resources due to duplicate kinds … #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…among different groupversions
epk
approved these changes
May 11, 2021
dschwar
approved these changes
May 11, 2021
timothysmith0609
force-pushed
the
multiple_kinds_affect_pruning
branch
from
13ec165
to
b90651f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cluster contains resources with identical
kindbut differentgroup/version, theClusterResourceDiscovererwill only find one of them, removing the other from the prune-whitelist. This is undesirable behaviour as it may cause (has caused!) deploys to fail to prune old resources.Note: This fix will cause the log output for a pruned resource to be repeated twice if the resource exists in different API groups. E.g. in older k8s versions,
Deploymentcould be found in theappsandextensionsgroups.