New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ERB.new deprecations #828

Merged

timothysmith0609 merged 1 commit into master from erb-deprecations

May 28, 2021

Contributor

casperisfine commented May 27, 2021

Positional arguments are deprecated and will start printing deprecations in Ruby 3.1

/tmp/bundle/ruby/3.1.0/gems/krane-2.1.8/lib/krane/renderer.rb:59: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.


          Fix ERB.new deprecations

873ba3b

casperisfine requested a review from a team as a code owner

May 27, 2021 11:37

timothysmith0609 approved these changes

View reviewed changes

timothysmith0609 merged commit 26bbdbe into master

timothysmith0609 deleted the erb-deprecations branch

May 28, 2021 12:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment