Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Evicted Pods in DaemonSet deployments #883

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Ignore Evicted Pods in DaemonSet deployments #883

merged 1 commit into from
Apr 1, 2022

Conversation

wayt
Copy link
Contributor

@wayt wayt commented Apr 1, 2022

Related to #881

Another case where DaemonSet deployment fails, when a node condition triggers an eviction, such as:

On the Pod:

status:
  message: 'Pod The node had condition: [DiskPressure]. '
  phase: Failed
  reason: Evicted
  startTime: "2022-03-31T20:14:06Z"

On the node:

spec:
  - effect: NoSchedule
    key: node.kubernetes.io/disk-pressure
    timeAdded: "2022-03-31T20:27:09Z"
status:
  conditions:
    - lastHeartbeatTime: "2022-03-31T20:27:29Z"
    lastTransitionTime: "2022-03-31T20:27:09Z"
    message: kubelet has disk pressure
    reason: KubeletHasDiskPressure
    status: "True"
    type: DiskPressure

This PR removes Evicted Pods from the list of Pod we expect to be ready for a DaemonSet deployment to be successful.

@wayt wayt requested review from dalehamel and KnVerey April 1, 2022 12:55
@wayt wayt requested a review from a team as a code owner April 1, 2022 12:55
@wayt wayt requested review from ethanaubuchon and devonboyer and removed request for a team April 1, 2022 12:55
@wayt wayt merged commit 8c7fca3 into master Apr 1, 2022
@wayt wayt deleted the evicted-pod branch April 1, 2022 16:56
@wayt wayt mentioned this pull request Apr 1, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems April 1, 2022 19:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants