Update YAML.safe_load call to be compatible with Ruby 3.1 #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds Ruby 3.1 tests to the GitHub actions matrix (similar to #887, so this PR can likely supplant that one)
jhoos
requested review from
JamesOwenHall and
RRethy
and removed request for
a team
|
This PR can replace #887, as it adds the same GitHub action configuration, and fixes the error that the author of that PR likely saw. |
peiranliushop
approved these changes
Jul 26, 2022
|
Are you going to release a new version? |
|
@jpfourny Releasing a new version would be the easiest way for our clusters to consume it. I wasn't sure if I'd be overstepping by doing that but if you want I'd be happy to do so. |
|
I will open a new PR to cut a 2.4.9 release |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
When krane is run under Ruby 3.1, and is invoked with an argument like
--bindings=@somefile, it crashes, because the binding code is loadingsomefileusing a deprecated call format forYAML.safe_loadthat is no longer valid in Ruby 3.1.This is also causing unit test failures when the tests are run under Ruby 3.1.
How is this accomplished?
The
safe_loadcall is fixed to use the current arguments, which are valid for Ruby 2.7 and later.What could go wrong?
Probably nothing since there's test coverage for this. The PR also adds Ruby 3.1 to the GitHub action test matrix to cover this case.