Remove unsupported Kubernetes and Ruby versions from Krane and CI #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve readme regarding the versions that are maintained by upstream and versions that we run integration tests. Bump the required tools to match what currently is maintained by upstream Kubernetes and Ruby projects.
KnVerey
reviewed
Sep 23, 2022
| @@ -546,77 +546,6 @@ def test_batch_dry_run_apply_success_precludes_individual_resource_dry_run_valid | |||
| ], in_order: true) | |||
| end | |||
|
|
|||
| # Note: After we drop support for K8s 1.21 this test can be removed, since webhooks must be dry-run safe. | |||
There was a problem hiding this comment.
Is there matching code that was making this work with <=1.21 that should also be removed?
There was a problem hiding this comment.
Yes, all this PR needs to be reverted #798 as there are no more sideeffects during dry-run for mutatingwebhook
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#webhook-resources-v122
There was a problem hiding this comment.
reverted in 9f1fe2a
and remove duplicate item for k8s 1.23
d1egoaz
force-pushed
the
d1egoaz_remove-unsupported-k8s-versions
branch
3 times, most recently
from
22dcd73
to
da36068
Compare
d1egoaz
changed the title
d1egoaz
requested review from
orcephrye and
aajoslinify
and removed request for
a team
d1egoaz
force-pushed
the
d1egoaz_remove-unsupported-k8s-versions
branch
2 times, most recently
from
c23a810
to
5cdaa8f
Compare
d1egoaz
force-pushed
the
d1egoaz_remove-unsupported-k8s-versions
branch
from
5cdaa8f
to
a15fa06
Compare
I was thinking to bump soon to a major version to signal the breaking change, and add new changes on top of the new version. |
JamesOwenHall
approved these changes
Oct 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
How is this accomplished?
✂️
What could go wrong?
Users of unsupported k8s or ruby versions will be stuck in the Krane 2.4.9 version and only get fixes and new features until migrated to newer supported versions.