s/whitelist/allowlist #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothysmith0609
force-pushed
the
tsmith/use-allowlist
branch
from
48287df
to
f442cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Closes #917
How is this accomplished?
global search and replace all whitelist references and change to allowlist
What could go wrong?
From what I understand,
--prune-allowlistis only available in 1.26+, so any clusters running older versions will not have access. This necessitates, at the very least, a minor version bump. I've added compatibility code so older k8s versions will still work with the old--prune-whitelistflagNote: Failing CI is due to flaky tests: I'm slowly rerunning them one-by-one to get 🟢