-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch dry run but like for real this time #943
Closed
timothysmith0609
wants to merge
19
commits into
main
from
tsmith/batch-dry-run-but-like-for-real-this-time
Closed
Changes from 3 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d319915
If we're going to batch dry run, then let's actually use the results
timothysmith0609 358f91c
Revert "If we're going to batch dry run, then let's actually use the …
timothysmith0609 e5fe76b
avoid needless per-resource dry-run apply validation
timothysmith0609 ac10cce
Use non-applyed resource to test per-resource validation
timothysmith0609 415ff19
Still need to do other resource validation even if batched dry run su…
timothysmith0609 1d15998
Test fixes
timothysmith0609 d58b46a
fix serial
timothysmith0609 94d5c77
testing
timothysmith0609 4abbac6
Fix backwards dry-run apply failure logic
timothysmith0609 2e386ed
fix serial tests
timothysmith0609 95f2a6d
Fix tests
timothysmith0609 924f6c0
rebasish
timothysmith0609 40c4d46
fix test
timothysmith0609 3b8cfff
more parallelize test
timothysmith0609 98818e7
fix ci
timothysmith0609 7fd0e3f
fix bad error
timothysmith0609 2c7ad38
test fix
timothysmith0609 7c30468
comment out broken test
timothysmith0609 2bf697d
Try client-side apply
timothysmith0609 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally I wanted to to just trust the output of the batched dry run test and raise a
FatalDeploymentError
. However, that made it very difficult to give a consistent UX with regards to giving useful feedback: the main issue being it became necessary to suppress all feedback if a sensitive document/secret was contained in the apply set.To that end, I've kept things pretty similar, just removing resources from the per-resource checks if batched dry-run succeeds. If it fails, since that's a less common case, we default to per-resource checking in order to provide more granular feedback and highlight what the actual issue it. This is the difference between "Something somewhere went wrong" and "THIS particular file and THIS particular line are wrong".