Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for service objects #353

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Add support for service objects #353

merged 1 commit into from
Jul 29, 2021

Conversation

rxbchen
Copy link
Contributor

@rxbchen rxbchen commented Jul 28, 2021

Description

Add support for k8s Services Object

Type of change
  • Bug fix πŸ›
  • New feature ✨
  • This change requires a documentation update πŸ“–
  • Breaking changes ⚠️
Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

Base automatically changed from public-pkg to main July 28, 2021 18:54
genevieveluyt
genevieveluyt previously approved these changes Jul 29, 2021
Co-authored-by: Dani <santos.adaniele@gmail.com>
@rxbchen rxbchen merged commit 50c618b into main Jul 29, 2021
@rxbchen rxbchen deleted the add-service-support branch July 29, 2021 20:46
@ghost
Copy link

ghost commented Jul 29, 2021

Congrats on merging your first pull request, keep em coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants