Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: tidy with 1.17 #521

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix CI: tidy with 1.17 #521

merged 1 commit into from
Jan 31, 2023

Conversation

genevieveluyt
Copy link
Contributor

@genevieveluyt genevieveluyt commented Jan 30, 2023

Description

CI is failing on PRs example

Run make setup
go mod download
go mod tidy
go: downloading k8s.io/klog v1.0.0
go: downloading golang.org/x/crypto v0.1.0
github.com/Shopify/kubeaudit/internal/k8sinternal imports
	k8s.io/client-go/plugin/pkg/client/auth/azure imports
	github.com/Azure/go-autorest/autorest/adal imports
	golang.org/x/crypto/pkcs12 loaded from golang.org/x/crypto@v0.0.0-20220214200702-8[6](https://github.com/Shopify/kubeaudit/actions/runs/3965679250/jobs/6795640603#step:6:7)341886e292,
	but go 1.16 would select v0.1.0
github.com/Shopify/kubeaudit/internal/k8sinternal imports
	k8s.io/client-go/plugin/pkg/client/auth/azure imports
	github.com/Azure/go-autorest/autorest/adal imports
	golang.org/x/crypto/pkcs12 imports
	golang.org/x/crypto/pkcs12/internal/rc2 loaded from golang.org/x/crypto@v0.0.0-20220214200[7](https://github.com/Shopify/kubeaudit/actions/runs/3965679250/jobs/6795640603#step:6:8)02-[8](https://github.com/Shopify/kubeaudit/actions/runs/3965679250/jobs/6795640603#step:6:9)6341886e2[9](https://github.com/Shopify/kubeaudit/actions/runs/3965679250/jobs/6795640603#step:6:10)2,
	but go 1.16 would select v0.1.0

To upgrade to the versions selected by go 1.[16](https://github.com/Shopify/kubeaudit/actions/runs/3965679250/jobs/6795640603#step:6:17):
	go mod tidy -go=1.16 && go mod tidy -go=1.[17](https://github.com/Shopify/kubeaudit/actions/runs/3965679250/jobs/6795640603#step:6:18)
If reproducibility with go 1.16 is not needed:
	go mod tidy -compat=1.17
For other options, see:
	https://golang.org/doc/modules/pruning
make: *** [Makefile:50: setup] Error 1
Error: Process completed with exit code 2.
Type of change
  • Bug fix πŸ›
  • New feature ✨
  • This change requires a documentation update πŸ“–
  • Breaking changes ⚠️ (removes backwards compatibility with go 1.16)
How Has This Been Tested?
  • Test A
  • Test B
Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

Copy link
Contributor

@dani-santos-code dani-santos-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it! πŸ™

@genevieveluyt genevieveluyt merged commit e5e27da into main Jan 31, 2023
@genevieveluyt genevieveluyt deleted the fix-ci branch January 31, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants