Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unmarshal errors not found for known k8s schema #571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fedeztk
Copy link

@fedeztk fedeztk commented Sep 1, 2023

Description

Fixes #523 (known schema not raising errors when incompatible with k8s resource definitions)

Type of change
  • Bug fix πŸ›
  • New feature ✨
  • This change requires a documentation update πŸ“–
  • Breaking changes ⚠️
How Has This Been Tested?

Tested using the example provided in #523. Prior to this change there was no error; now, known resources (e.g. Deployments) raise an error when the unmarshaling goes wrong (like unquoted labels) and clearly shows that there is a misconfiguration in the manifest.

Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not finding errors in deployment
1 participant