Prevent deploys from failing if pod is evicted #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnVerey
reviewed
May 22, 2018
| @@ -155,6 +155,21 @@ def test_deploy_failed_is_true_for_container_cannot_run_error | |||
| assert_equal expected_msg, pod.failure_message | |||
| end | |||
|
|
|||
| def test_deploy_failed_is_false_for_evicted_ | |||
There was a problem hiding this comment.
nit: you've got a trailing underscore (maybe you meant to add "pods"?)
| @@ -155,6 +155,21 @@ def test_deploy_failed_is_true_for_container_cannot_run_error | |||
| assert_equal expected_msg, pod.failure_message | |||
| end | |||
|
|
|||
| def test_deploy_failed_is_false_for_evicted_ | |||
| container_state = { | |||
There was a problem hiding this comment.
Did this test really fail without your change? This is setting container status info, but eviction data (as your business logic correctly assumes) is at the top level of the pod status, like this:
status:
message: 'The node was low on resource: nodefs.'
phase: Failed
reason: Evicted
startTime: 2018-05-04T21:17:08Z
It didn't, probably because I guessed at what the status looks like for an evicted pod. I've updated the test based on |
KnVerey
approved these changes
May 23, 2018
dturn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evictions should be recoverable so don't let them cause a failure.
Fixes: #230