Relax googleauth versions #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnVerey
approved these changes
Sep 19, 2018
kubernetes-deploy.gemspec
Outdated
| @@ -25,7 +25,7 @@ Gem::Specification.new do |spec| | |||
| spec.required_ruby_version = '>= 2.3.0' | |||
| spec.add_dependency "activesupport", ">= 5.0" | |||
| spec.add_dependency "kubeclient", "~> 3.0" | |||
| spec.add_dependency "googleauth", "= 0.6.2" # https://github.com/google/google-auth-library-ruby/issues/153 | |||
| spec.add_dependency "googleauth", "~> 0.6.4" # https://github.com/google/google-auth-library-ruby/issues/153 | |||
There was a problem hiding this comment.
Should we do "~> 0.6", ">= 0.6.4" to allow minor version upgrades?
dturn
approved these changes
Sep 20, 2018
|
@stefanmb any reason this stalled? |
Bumping the version caused test failures, haven't had a chance to investigate. Downgrading my dependency unblocked me. |
stefanmb
commented
Oct 18, 2018
| @@ -14,7 +14,7 @@ def teardown | |||
| def test_auth_use_default_gcp_success | |||
| config = KubernetesDeploy::KubeclientBuilder::GoogleFriendlyConfig.new(kubeconfig, "") | |||
|
|
|||
| stub_request(:post, 'https://www.googleapis.com/oauth2/v4/token') | |||
| stub_request(:post, 'https://oauth2.googleapis.com/token') | |||
There was a problem hiding this comment.
This is a legitimate change introduced by googleapis/google-auth-library-ruby#147.
Note that there isn't much in the way of docs in that PR, and the old version we used (0.6.2) has no tag associated with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue googleapis/google-auth-library-ruby#153 was resolved and released in
0.6.4https://github.com/googleapis/google-auth-library-ruby/pull/154/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR3.