Task config kubectl #584
Merged
Task config kubectl #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturn
force-pushed
the
task-config-kubectl
branch
3 times, most recently
from
23729be
to
2d1b3c5
Compare
dturn
force-pushed
the
task-config-kubectl
branch
from
2d1b3c5
to
49a3001
Compare
Fix up tests
dturn
force-pushed
the
task-config-kubectl
branch
from
49a3001
to
6977f6f
Compare
dirceu
approved these changes
Oct 9, 2019
Taking a look at codecov it does look like everything is covered. I'm not really worried about the tasks breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Make it easy to have a global-deploy command. #574 has shown that some objects validate too much, e.g. Kubectl validates its passes a namespace, but it shouldn't if it's only going to be used for global commands.
By pushing TaskConfig in more places it should become easier to feel good about limiting validations in non-task classes.
This doesn't finish #572, we still need to pass it to the Resource objects. But this already hits 19 files.
How is this accomplished?
Pass TaskConfig instances around. Remove some validations in Kubectl.
What could go wrong?
Test coverage is lacking ...