Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Lighthouse failed with exit code 1 - DNS_FAILURE #42

Closed
3daddict opened this issue May 13, 2022 · 6 comments
Closed

Error: Lighthouse failed with exit code 1 - DNS_FAILURE #42

3daddict opened this issue May 13, 2022 · 6 comments

Comments

@3daddict
Copy link

I can't seem to find my way out of this error:

"lighthouseVersion": "8.0.0",
  "fetchTime": "2022-05-13T15:23:00.779Z",
  "requestedUrl": "https://***/?preview_theme_id=130421096632&_fd=0&pb=0",
  "finalUrl": "https://***/?preview_theme_id=130421096632&_fd=0&pb=0",
  "runWarnings": [
    "DNS servers could not resolve the provided domain."
  ],
  "runtimeError": {
    "code": "DNS_FAILURE",
    "message": "DNS servers could not resolve the provided domain."
  },

Here is my current action file

name: CI
on: [push]
jobs:
  lhci:
    name: Lighthouse
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - name: Lighthouse
        uses: shopify/lighthouse-ci-action@1.0
        with:
          theme_root: ./dist
          store: ${{ secrets.SHOP_STORE }}
          access_token: ${{ secrets.SHOP_ACCESS_TOKEN }}
          product_handle: ${{ secrets.SHOP_PRODUCT_HANDLE }}
          collection_handle: ${{ secrets.SHOP_COLLECTION_HANDLE }}
          lhci_github_app_token: ${{ secrets.LHCI_GITHUB_APP_TOKEN }}
          lhci_min_score_performance: 0.6
          lhci_min_score_accessibility: 0.9

I think I have everything passing as expected?

==============================
Configuring shopify CLI
Will run Lighthouse CI on https://***
==============================
Creating development theme
{"theme":{"id":130421293240,"name":"Development (b11ff0-f8e7f7bbfacc)","role":"development","shop":"***.myshopify.com","editor_url":"https://***.myshopify.com/admin/themes/130421293240/editor","preview_url":"https://***.myshopify.com/?preview_theme_id=130421293240"}}
==============================
Configuring Lighthouse CI
==============================
Running Lighthouse CI
✅  .lighthouseci/ directory writable
✅  Configuration file found
✅  Chrome installation found
✅  GitHub token set
Healthcheck passed!
Getting a new page...
Getting preview cookie...
Running Lighthouse 3 time(s) on https://***/?preview_theme_id=1304[21](https://github.com/***/***runs/6425936387?check_suite_focus=true#step:4:21)293[24](https://github.com/***/***/runs/6425936387?check_suite_focus=true#step:4:24)0&_fd=0&pb=0
@3daddict
Copy link
Author

3daddict commented May 14, 2022

I wonder is this because the store is a dev store and a password is required?
Anyway around this or this can only be used on stores that are not password protected?

@charlespwd
Copy link
Collaborator

charlespwd commented May 16, 2022

My guess is that there's an error in ${{ secrets.SHOP_STORE }}, are you certain it contains the .myshopify.com part?
e.g. valid values are something like:
shimmering-islands.myshopify.com

We might need to clarify the docs to make it more obvious.

@3daddict
Copy link
Author

Thanks @charlespwd ,
That was the issue, I has entered xxx instead of xxx.myshopify.com.
I could have sworn I tried both but it probably was before I added the default product_handle or something.
But yeah maybe instead of <domain>.myshopify.com this might be more clear for sleep deprived like myself <domain.myshopify.com>.
Thanks again for the suggestion that did the trick!
image

charlespwd added a commit that referenced this issue May 17, 2022
It's not obvious that we need the .myshopify.com part. This _should_ help. 

Fixes #42
@charlespwd
Copy link
Collaborator

Hey @3daddict, I modified the docs to say

  • store - (required) Shopify store Admin URL, e.g. my-store.myshopify.com.

Hopefully that will be clearer 🤞

@3daddict
Copy link
Author

Thanks @charlespwd! This lighthouse-ci-action and the theme-check-action are really useful tools.

@Al-Amin-Khan-Shakil
Copy link

image
I am facing this lighthouse errors I don't know why, Is there anyone who will be kind enough to help me. I am putting the pull request link bellow
Al-Amin-Khan-Shakil/FinanceHorizons-Business-Conference#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants