Skip to content

Commit

Permalink
Merge pull request #48 from Shopify/rubocop-extensions
Browse files Browse the repository at this point in the history
add extensions
  • Loading branch information
sbfaulkner committed Oct 28, 2023
2 parents 12413df + 7b87d66 commit 6121891
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 4 deletions.
4 changes: 4 additions & 0 deletions .rubocop.yml
Expand Up @@ -3,6 +3,10 @@ inherit_from: .rubocop_todo.yml
inherit_gem:
rubocop-shopify: rubocop.yml

require:
- rubocop-minitest
- rubocop-rake

AllCops:
NewCops: enable
TargetRubyVersion: 3.2
21 changes: 17 additions & 4 deletions .rubocop_todo.yml
@@ -1,12 +1,12 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2023-10-28 21:01:55 UTC using RuboCop version 1.57.2.
# on 2023-10-28 21:14:44 UTC using RuboCop version 1.57.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
# Include: **/*.gemspec
Expand Down Expand Up @@ -42,6 +42,19 @@ Lint/MissingSuper:
Exclude:
- 'test/test_helper.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Minitest/AssertOperator:
Exclude:
- 'test/limiter/clock_test.rb'

# Offense count: 5
# This cop supports safe autocorrection (--autocorrect).
Minitest/EmptyLineBeforeAssertionMethods:
Exclude:
- 'test/limiter/mixin_test.rb'
- 'test/limiter/rate_queue_test.rb'

# Offense count: 1
# Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, CheckDefinitionPathHierarchyRoots, Regex, IgnoreExecutableScripts, AllowedAcronyms.
# CheckDefinitionPathHierarchyRoots: lib, spec, test, src
Expand Down Expand Up @@ -74,7 +87,7 @@ Style/FrozenStringLiteralComment:
Exclude:
- 'lib/ruby-limiter.rb'

# Offense count: 19
# Offense count: 21
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: IgnoreMacros, AllowedMethods, AllowedPatterns, IncludedMacros, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, AllowParenthesesInStringInterpolation, EnforcedStyle.
# SupportedStyles: require_parentheses, omit_parentheses
Expand All @@ -96,7 +109,7 @@ Style/SafeNavigation:
Exclude:
- 'lib/limiter/rate_queue.rb'

# Offense count: 46
# Offense count: 50
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Expand Down
2 changes: 2 additions & 0 deletions limiter.gemspec
Expand Up @@ -36,4 +36,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rubocop', '~> 1.57'
spec.add_development_dependency 'code-scanning-rubocop', '~> 0.6.1'
spec.add_development_dependency 'rubocop-shopify', '~> 2.14'
spec.add_development_dependency 'rubocop-minitest', '~> 0.33.0'
spec.add_development_dependency 'rubocop-rake', '~> 0.6.0'
end

0 comments on commit 6121891

Please sign in to comment.