Add support for sections tag #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veken1199
requested review from
mgmanzella and
charlespwd
and removed request for
mgmanzella
|
Did you use the |
Running
|
veken1199
force-pushed
the
feature/new-sections-liquid-tag
branch
2 times, most recently
from
d9801a8
to
8441d01
Compare
veken1199
force-pushed
the
feature/new-sections-liquid-tag
branch
from
8441d01
to
5a7a49c
Compare
|
I added test case |
|
Oh yeah gotcha. Had to double check but that's indeed the case 👌 |
charlespwd
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
As we are planning to introduce a new liquid tag to render section groups, we want to make sure liquid-tm-grammar is able to recognize and handle the new liquid tag.
The new sections tag is use as followed:
{% sections '<type>%}`