allow nil template source

Shopify · Jan 10, 2024 · 730ad36 · 730ad36
1 parent 3ac7e47
commit 730ad36
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/liquid/template.rb b/lib/liquid/template.rb
@@ -108,7 +108,7 @@ def initialize
     def parse(source, options = {})
       parse_context = configure_options(options)
 
-      unless source.valid_encoding?
+      if source.is_a?(String) && !source.valid_encoding?
         raise SyntaxError, parse_context.locale.t("errors.syntax.invalid_template_encoding")
       end
 

diff --git a/test/integration/template_test.rb b/test/integration/template_test.rb
@@ -349,4 +349,9 @@ def test_raises_error_with_invalid_utf8
 
     assert_equal('Liquid syntax error: Invalid template encoding', e.message)
   end
+
+  def test_allows_nil_as_source
+    template = Template.parse(nil)
+    assert_equal('', template.render)
+  end
 end