Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying filters for parsing #1314

Open
dylanahsmith opened this issue Oct 14, 2020 · 0 comments
Open

Add support for specifying filters for parsing #1314

dylanahsmith opened this issue Oct 14, 2020 · 0 comments

Comments

@dylanahsmith
Copy link
Contributor

Currently filters are only provided as a render option, which prevents us from checking if a filter call is valid during parsing and providing faster feedback about a bug in a template.

Also, we would like to use information about what filters will be available, along with what parameters they take, in liquid-c. That will allow us to skip render time checks to see if a filter is invokable and avoid the need to translate ArgumentError exceptions to Liquid::ArgumentError from passing in the wrong number of arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant