You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Template.parse("{{ (true..false) }}") throws a NoMethodError .to_i on TrueClass.
I had a partial fix in 185ad2e, but it looks like that's breaking lax parse with an extra dot by throwing an Liquid::ArgumentError instead of rendering.
Don't really have more time to put on this right now so I'm opening an issue instead :D
The text was updated successfully, but these errors were encountered:
Seems like we can just rescue a NoMethodError from start_obj.to_i..end_obj.to_i and turn it into a Liquid::SyntaxError with an appropriate message. There is no need to tolerate this, since it already wasn't working and the liquid code is clearly wrong
Liquid::Template.parse('{{ ((1..2)..3) }}') is another way to get that NoMethodError, by causing it to call .to_i on a Range object.
Template.parse("{{ (true..false) }}")
throws a NoMethodError.to_i
on TrueClass.I had a partial fix in 185ad2e, but it looks like that's breaking lax parse with an extra dot by throwing an Liquid::ArgumentError instead of rendering.
Don't really have more time to put on this right now so I'm opening an issue instead :D
The text was updated successfully, but these errors were encountered: