Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

| json filter not escaping properly with mix of angle quotes and regular quotes #969

Open
rickmurt opened this issue Jan 18, 2018 · 0 comments
Open

| json filter not escaping properly with mix of angle quotes and regular quotes #969

rickmurt opened this issue Jan 18, 2018 · 0 comments

Comments

@rickmurt
Copy link

Hi there,

I've found a bug with the liquid | json
filter not escaping properly if a product description has a mix of regular quote marks (this guy: ' ) and angle quote marks (this guy: ’)

selection_932

I put together a screencast explaning how to reproduce this and how to make a temporary fix: https://youtu.be/yjO3m-kMdZU

Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rickmurt