Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all constants to SCREAMING_SNAKE_CASE #1159

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

shopmike
Copy link
Contributor

This changes all constants to SCREAMING_SNAKE_CASE. It provides backward support through liquid/legacy

@Shopify/liquid

@ashmaroli
Copy link
Contributor

@shopmike If you don't mind, can you align the = operators in the legacy.rb to improve readability?
I understand that the contents there are meant for internal use only and for the short duration until Liquid 5.0.. But still... 😉

@shopmike
Copy link
Contributor Author

Maybe once this is in we can look at

Layout/ExtraSpacing:
  ForceEqualSignAlignment: true

I would be happy if the style guide at least did no spacing or equal spacing but it looks like it doesn't do either so might need to set this in the project rubocop.
https://github.com/Shopify/liquid/pull/1159/files#diff-1ac8d79c9833db7b503c16989031b253R36

@tobi
Copy link
Member

tobi commented Sep 19, 2019

Why are we not using ForceEqualSignAlignment? Seems like a nobrainer.

@shopmike shopmike added this to In progress in Ruby Style Sep 19, 2019
@shopmike
Copy link
Contributor Author

I tested it on this and agree its the right move. It's too big to apply here so I will do as new PR after this has made it through.

I'd like to get to a point where PR's don't contain styling feedback as the Rubocop config is solid.

lib/liquid.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Ruby Style
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants