New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change all constants to SCREAMING_SNAKE_CASE #1159
base: main
Are you sure you want to change the base?
Conversation
@shopmike If you don't mind, can you align the |
Maybe once this is in we can look at
I would be happy if the style guide at least did no spacing or equal spacing but it looks like it doesn't do either so might need to set this in the project rubocop. |
Why are we not using ForceEqualSignAlignment? Seems like a nobrainer. |
This reverts commit 26eb27f.
I tested it on this and agree its the right move. It's too big to apply here so I will do as new PR after this has made it through. I'd like to get to a point where PR's don't contain styling feedback as the Rubocop config is solid. |
Align equals operator in `lib/liquid/legacy.rb`
This changes all constants to SCREAMING_SNAKE_CASE. It provides backward support through
liquid/legacy
@Shopify/liquid