allow non-string template source #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdoiron
reviewed
Jan 10, 2024
lib/liquid/template.rb
Outdated
| @@ -108,7 +108,7 @@ def initialize | |||
| def parse(source, options = {}) | |||
| parse_context = configure_options(options) | |||
|
|
|||
| unless source.valid_encoding? | |||
| if source.is_a?(String) && !source.valid_encoding? | |||
There was a problem hiding this comment.
What if the to_s value is a string with an invalid encoding?
There was a problem hiding this comment.
Good catch... That is possible...
class ByteString
def to_s
"\xC0"
end
end
Liquid::Template.parse(ByteString.new) # this should raise an errorI have updated the PR to convert the source to a String object from the Template#parse function instead of Tokenize#initialize.
ggmichaelgo
changed the title
|
Wait what? How/when does this happen? |
alexcoco
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to solve?
#1774 introduced a bug that doesn't allow non-string values such as
nilorIntegeras a template source.Expected behaviour:
How are you solving this?
This PR updates the
Template#parseto only check the template's validity if the template is aString