Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid UTF-8 support #185

Merged
merged 2 commits into from Apr 23, 2013
Merged

Liquid UTF-8 support #185

merged 2 commits into from Apr 23, 2013

Conversation

ozeias
Copy link
Contributor

@ozeias ozeias commented Apr 23, 2013

Adds support for UTF-8 word characters in Ruby 1.9 that is also backwards compatible with 1.8 from #164

Before:

@template = Liquid::Template.parse("hi {{ordem_número}}")
@template.render( 'ordem_número' => '201300000000017' )
=> "hi "

After:

@template = Liquid::Template.parse("hi {{ordem_número}}")
@template.render( 'ordem_número' => '201300000000017' )
=> "hi 201300000000017"

@boourns & @Soleone & @dylanahsmith for review

@daviscabral
Copy link

👍

@Soleone
Copy link
Member

Soleone commented Apr 23, 2013

does look good to me 👍

@boourns
Copy link

boourns commented Apr 23, 2013

👍

boourns pushed a commit that referenced this pull request Apr 23, 2013
@boourns boourns merged commit c5dfcd2 into Shopify:master Apr 23, 2013
boourns pushed a commit that referenced this pull request May 20, 2013
This reverts commit c5dfcd2, reversing
changes made to f7d1e1d.
boourns pushed a commit that referenced this pull request May 21, 2013
Revert "Merge pull request #185 from ISSIntel/liquid-utf8"
@ryanwood ryanwood mentioned this pull request Dec 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants