Add default encoding for CSV #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etiennebarrie I updated from your review. |
|
@etiennebarrie any other issue I can address for the UTF-8 in the CSV? |
|
Rebase to fix CI errors |
ActiveStorage fetch files as ASCII-8BIT. The CSV fails to open any files with non ASCII characters. With this change the CSV is open with `Encoding.default_external` which use the `ENV["LANG"]`.
Update the tests in accordance. Remove the encoding override.
Co-authored-by: Étienne Barrié <etienne.barrie@gmail.com>
|
@etiennebarrie thank you, I rebased and tested rubocop locally, all greens (in ruby 3.3.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveStorage fetch files as ASCII-8BIT. The CSV fails to open any files with non ASCII characters. With this change the CSV is open with
Encoding.default_externalwhich use theENV["LANG"].