Task generator for generating new maintenance tasks #115
Conversation
adrianna-chang-shopify
force-pushed
the
generator-for-new-tasks
branch
4 times, most recently
from
0b1fdc9
to
1e8773f
Compare
adrianna-chang-shopify
force-pushed
the
generator-for-new-tasks
branch
from
1e8773f
to
50b8d8d
Compare
adrianna-chang-shopify
requested review from
etiennebarrie and
volmer
and removed request for
etiennebarrie and
volmer
adrianna-chang-shopify
force-pushed
the
generator-for-new-tasks
branch
2 times, most recently
from
e7b6b38
to
570108e
Compare
adrianna-chang-shopify
force-pushed
the
generator-for-new-tasks
branch
from
570108e
to
40a7da3
Compare
| require 'test_helper' | ||
| module Maintenance | ||
| <% module_namespacing do -%> | ||
| class <%= class_name %>TaskTest < ActiveSupport::TestCase |
There was a problem hiding this comment.
We could check which testing framework they're using and generate the correct template (ie. test vs spec), but I think this is sufficient.
There was a problem hiding this comment.
There's a concept of hooks where our generator could call a different other generator, I think it could work where this could call a different testing framework, or even none if the rails app was generated without tests.
https://api.rubyonrails.org/classes/Rails/Generators/Base.html#method-c-hook_for
But I also think this is enough for this PR, we could look into later maybe.
| require 'test_helper' | ||
| module Maintenance | ||
| <% module_namespacing do -%> | ||
| class <%= class_name %>TaskTest < ActiveSupport::TestCase |
There was a problem hiding this comment.
There's a concept of hooks where our generator could call a different other generator, I think it could work where this could call a different testing framework, or even none if the rails app was generated without tests.
https://api.rubyonrails.org/classes/Rails/Generators/Base.html#method-c-hook_for
But I also think this is enough for this PR, we could look into later maybe.
adrianna-chang-shopify
force-pushed
the
generator-for-new-tasks
branch
from
767c99c
to
5a5af74
Compare
adrianna-chang-shopify
force-pushed
the
generator-for-new-tasks
branch
from
5a5af74
to
d87d4c1
Compare
Closes: #105
Creates a
MaintenanceTaskGeneratorthat can be invoked usingrails generate maintenance_tasks foo, which will createfoo_task.rbinapp/tasks/maintenance, as well astest/tasks/maintenance/foo_task_test.rb.Generated tasks have a template that follows the API we've outlined in the README.