Allow tasks to be loaded from nested task directories #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styrmis
force-pushed
the
allow-nested-tasks
branch
from
ff536d8
to
13989bf
Compare
There was a problem hiding this comment.
#752 was already a fix in progress for this, maybe you can combine the two since we were waiting for the tests? That other implementation used a lambda to recursively load all the constants defined in modules found in namespace, which seems more correct.
styrmis
force-pushed
the
allow-nested-tasks
branch
from
13989bf
to
2e46061
Compare
|
Thanks @etiennebarrie, I wasn't aware of that one. I've cherry-picked the commit from that PR and have extended the tests to cover two levels of nesting. I've also added a section to the README. |
etiennebarrie
approved these changes
Apr 19, 2023
This was referenced Apr 19, 2023
Merged
lawrencewong
pushed a commit
to lawrencewong/maintenance_tasks
that referenced
this pull request
Apr 29, 2023
Co-authored-by: Masa (Aileron inc) <masa@aileron.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In shop-server we have tasks which are in sub-folders (e.g.
app/tasks/maintenance/deep_understanding). These are available in production, but in development they are not automatically loaded, making them harder to test (TODO: verify this).Before this PR, only tasks directly under
app/taskswill be loaded in development. After this commit, one level of nesting is supported.