Add helper text to datetime-local form fields #833
Conversation
| # Return helper text for the datetime-local form field. | ||
| def datetime_field_help_text | ||
| tag.div( | ||
| tag.p("Datetime inputs will use the system timezone, which is #{Time.now.zone}."), |
There was a problem hiding this comment.
This may become incorrect if ActiveModel::Type::DateTime ever handles local times in accordance with Rails.configuration.time_zone/Time.zone. We should add a test for that to make sure we update this if it changes.
e.g. currently, ActiveModel::Type::DateTime.new.cast("2023-06-01T12:00:00") will not respect Time.zone but only the system time zone.
We could write a test that changes Time.zone to something that's not Time.now.zone, then tries to parse a local time as sent by a browser and checks that the timezone is correct.
There was a problem hiding this comment.
Actually it's already incorrect if the application is not setting config.time_zone. In this case, it will always use UTC. If config.time_zone is set, it won't use it but use the system time zone instead… It will always ignore Time.zone though.
etiennebarrie
force-pushed
the
ac-timezone-text-helper-on-datetime-inputs
branch
2 times, most recently
from
4a28350
to
914af37
Compare
Currently, datetime form fields are ambiguous because it's unclear whether the application timezone or system timezone will be used. This commit adds helper text to datetime form fields specifying which timezone will be used for datetime-local parameter inputs. Co-authored-by: Étienne Barrié <etienne.barrie@shopify.com>
etiennebarrie
force-pushed
the
ac-timezone-text-helper-on-datetime-inputs
branch
from
914af37
to
189fd85
Compare
|
@etiennebarrie is this ready to merge? |
|
Yes I think so! |
|
@etiennebarrie can you approve it and then I'll merge? 😅 |
adrianna-chang-shopify
deleted the
ac-timezone-text-helper-on-datetime-inputs
branch
Currently, datetime form fields are ambiguous because it's unclear whether the application timezone or system timezone will be used. This PR adds helper text to datetime form fields specifying that the system timezone will be used for datetime-local parameter inputs. We can even show the system timezone via
Time.now.zoneso that it's clearer for debugging purposes (e.g. local dev envs will use the user's local timezone vs prod generally using UTC).🎩