Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update job-iteration requirement from ~> 1.3.6 to >= 1.3.6, < 1.5.0 #874

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 28, 2023

Updates the requirements on job-iteration to permit the latest version.

Release notes

Sourced from job-iteration's releases.

v1.4.0

Changes

  • 338 - All logs are now ActiveSupport::Notifications events and logged using ActiveSupport::LogSubscriber to allow customization. Events now always include the cursor_position tag.
  • 418 - Return nil from Iteration#perform, to signal not to rely on return value.

Features

  • 240 - Allow setting inheritable per-job job_iteration_max_job_runtime
  • 310 - Support nested iteration
  • 341 - Add JobIteration.default_retry_backoff, which sets a default delay when jobs are re-enqueued after being interrupted. Defaults to nil, meaning no delay, which matches the current behaviour.
  • 365 - Support composite primary key as a cursor

Bug fixes

  • 289 - Fix uninitialized constant error when raising ConditionNotSupportedError from ActiveRecordBatchEnumerator
  • 346 - Include failed jobs in total_time
  • 417 - Ensure that numerical values are deserialized as such and not as strings.

Full Diff: Shopify/job-iteration@v1.3.6...v1.4.0

Changelog

Sourced from job-iteration's changelog.

v1.4.0 (Aug 23, 2023)

Changes

  • 338 - All logs are now ActiveSupport::Notifications events and logged using ActiveSupport::LogSubscriber to allow customization. Events now always include the cursor_position tag.
  • 418 - Return nil from Iteration#perform, to signal not to rely on return value.

Features

  • 240 - Allow setting inheritable per-job job_iteration_max_job_runtime
  • 310 - Support nested iteration
  • 341 - Add JobIteration.default_retry_backoff, which sets a default delay when jobs are re-enqueued after being interrupted. Defaults to nil, meaning no delay, which matches the current behaviour.
  • 365 - Support composite primary key as a cursor

Bug fixes

  • 289 - Fix uninitialized constant error when raising ConditionNotSupportedError from ActiveRecordBatchEnumerator
  • 346 - Include failed jobs in total_time
  • 417 - Ensure that numerical values are deserialized as such and not as strings.
Commits
  • 7e6c385 Merge pull request #423 from Shopify/mangara-release
  • 1297fe4 Release v1.4.0
  • d26f741 Merge pull request #420 from Shopify/blaze-it
  • 3556330 Merge pull request #421 from Shopify/dependabot/bundler/sorbet-runtime-0.5.10978
  • 10ee378 Bump sorbet-runtime from 0.5.10962 to 0.5.10978
  • e135a3e Merge pull request #422 from Shopify/dependabot/bundler/resque-2.6.0
  • b0e9d2c Bump resque from 2.5.0 to 2.6.0
  • 7d7cc47 Add missing CHANGELOG entry for nil return
  • 068f395 Avoid insert_all in test setup
  • 27e0517 Skip tests for Rails 5.2 on Ruby 3.2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Aug 28, 2023
Copy link
Contributor

@Schwad Schwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the last time this was bumped by @etiennebarrie here #583

It seems there's no blocking issues to expanding this requirement further looking at the changelog?

Updates the requirements on [job-iteration](https://github.com/shopify/job-iteration) to permit the latest version.
- [Release notes](https://github.com/shopify/job-iteration/releases)
- [Changelog](https://github.com/Shopify/job-iteration/blob/main/CHANGELOG.md)
- [Commits](Shopify/job-iteration@v1.3.6...v1.4.0)

---
updated-dependencies:
- dependency-name: job-iteration
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@adrianna-chang-shopify adrianna-chang-shopify force-pushed the dependabot/bundler/job-iteration-1.4.0 branch from 94fda4e to 102f1bc Compare August 31, 2023 19:22
@adrianna-chang-shopify adrianna-chang-shopify merged commit 920403c into main Aug 31, 2023
34 checks passed
@adrianna-chang-shopify adrianna-chang-shopify deleted the dependabot/bundler/job-iteration-1.4.0 branch August 31, 2023 19:25
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems September 12, 2023 13:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants