Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Commit

Permalink
Merge pull request #32 from Shopify/rails-master
Browse files Browse the repository at this point in the history
Run CI against rails master
  • Loading branch information
kmcphillips committed Dec 1, 2016
2 parents e85707f + a800ed8 commit 4cc9305
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,14 @@ cache: bundler
rvm:
- 2.1.8
- 2.2.4
- 2.3.0
- 2.3.1
gemfile:
- Gemfile
- gemfiles/rails-4.2.gemfile
- gemfiles/rails-master.gemfile
matrix:
exclude:
- gemfile: Gemfile
rvm: 2.1.8
- gemfile: gemfiles/rails-master.gemfile
rvm: 2.1.8
5 changes: 5 additions & 0 deletions gemfiles/rails-master.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
source 'https://rubygems.org'

gemspec path: '..'

gem 'rails', github: 'rails/rails'
4 changes: 2 additions & 2 deletions test/active_record_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ class Measured::Rails::ActiveRecordTest < ActiveSupport::TestCase
end

test "assigning a number with more significant digits than permitted by the column precision does not raise exception when it can be rounded to have lesser significant digits per column's scale" do
assert_nothing_raised Measured::Rails::Error do
assert_nothing_raised do
thing.height = Measured::Length.new(4.45678912123123123, :mm)
assert_equal thing.height_value, BigDecimal.new('4.46')
end
Expand All @@ -348,7 +348,7 @@ class Measured::Rails::ActiveRecordTest < ActiveSupport::TestCase
end

test "assigning a large number that's just smaller, equal to, and over the size of the column precision raises exception" do
assert_nothing_raised Measured::Rails::Error do
assert_nothing_raised do
thing.height = Measured::Length.new(99999999.99, :mm)
end

Expand Down

0 comments on commit 4cc9305

Please sign in to comment.