Prepare for 4.0.0 #634
Merged
Prepare for 4.0.0 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan-potter
approved these changes
Jan 21, 2020
MobileBuy/sample/src/shopify/java/com/shopify/sample/SampleApplication.java
Outdated
Show resolved
Hide resolved
jmignac
force-pushed
the
release-4.0.0
branch
2 times, most recently
from
1b2d08a
to
90f9c84
Compare
jmignac
force-pushed
the
release-4.0.0
branch
2 times, most recently
from
8a10c9e
to
006d1a4
Compare
tristan-potter
approved these changes
Jan 23, 2020
tanderson85
approved these changes
Jan 23, 2020
ershkia
reviewed
Jan 23, 2020
jmignac
force-pushed
the
release-4.0.0
branch
from
006d1a4
to
8862e2b
Compare
ershkia
reviewed
Jan 23, 2020
ershkia
reviewed
Jan 23, 2020
jmignac
force-pushed
the
release-4.0.0
branch
2 times, most recently
from
e91f6c4
to
f880cdd
Compare
ershkia
reviewed
Jan 23, 2020
| val httpCache = httpCacheConfig.let { config -> | ||
| when (config) { | ||
| is HttpCacheConfig.DiskLru -> { | ||
| val version = BuildConfig.VERSION_NAME | ||
| val tmp = (endpointUrl.toString() + "/" + version + "/" + accessToken).toByteArray(Charset.forName("UTF-8")) | ||
| val tmp = (endpointUrl.toString() + "/" + version + "/" + accessToken + "/" + locale).toByteArray(Charset.forName("UTF-8")) |
There was a problem hiding this comment.
@sav007 is this the only change needed to make caching work with different locales?
ershkia
reviewed
Jan 23, 2020
ershkia
approved these changes
Jan 23, 2020
jmignac
force-pushed
the
release-4.0.0
branch
from
f880cdd
to
25be3cc
Compare
jmignac
force-pushed
the
release-4.0.0
branch
from
25be3cc
to
c942067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
GraphClient.build()now can takelocaleas an extra param, that sets theAccept-Languageheader for retrieving translated values from Storefront API. Documentation updatedFKP,GIPandSHPcurrenciespresentmentUnitPrices,unitPriceandunitPriceMeasurementonProductVariantmediafield onProduct: