added filter to spanmetrics processor #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanner-bruce
approved these changes
May 2, 2022
ahayworth
pushed a commit
that referenced
this pull request
May 16, 2022
arun-shopify
added a commit
that referenced
this pull request
Jun 21, 2022
ahayworth
pushed a commit
that referenced
this pull request
Jun 23, 2022
sveiss
pushed a commit
that referenced
this pull request
Aug 2, 2022
arun-shopify
added a commit
that referenced
this pull request
Sep 30, 2022
arun-shopify
added a commit
that referenced
this pull request
Sep 30, 2022
* probabilisticsampler: add filterspan config * added filter to spanmetrics processor (#6) * prometheusexporter: use attributevalue * misc: reduce dependabot noise Because of the weird^H^H^H^H^Hinteresting structure of the contrib repo, we have an overwhelming amount of dependabot noise for this. Especially since we're behind upstream. We could turn this off entirely, I suppose. Or - we can modify the Makefile and just make this noise monthly rather than weekly. This commit is the result of modifying the `Makefile` to do monthly updates instead of weekly, as well as the result of running `make gendependabot`. * Monitoring spanmetrics (#797) * wip cache metric from spanmetrics * testing * testing * WIP: collecting metrics * metric name updated * Update exporter/prometheusexporter/prometheus.go Co-authored-by: tanner-bruce <b.r.uce.tanner@gmail.com> * Update processor/spanmetricsprocessor/processor.go Co-authored-by: tanner-bruce <b.r.uce.tanner@gmail.com> * wip error metrics * span metrics monitoring : refactored internal metrics counters * span metrics monitoring : added metricKey error * Update processor/spanmetricsprocessor/processor.go Co-authored-by: tanner-bruce <b.r.uce.tanner@gmail.com> * Update processor/spanmetricsprocessor/processor.go Co-authored-by: tanner-bruce <b.r.uce.tanner@gmail.com> * moved metric one loop up * unique metrics count * removed actice timeseries counter * Update processor/spanmetricsprocessor/processor.go Co-authored-by: tanner-bruce <b.r.uce.tanner@gmail.com> Co-authored-by: tanner-bruce <b.r.uce.tanner@gmail.com> * fix some merging issues Co-authored-by: Tanner Bruce <tanner.bruce@shopify.com> Co-authored-by: Andrew Hayworth <andrew.hayworth@shopify.com> Co-authored-by: tanner-bruce <b.r.uce.tanner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.