Merge pull request #269 from Shopify/ae-fix-bug-with-offenses-formatter

Require OffensesFormatter in Configuration
Shopify · Nov 29, 2022 · 7dcccdb · 7dcccdb
2 parents d447a38 + 8e4e256
commit 7dcccdb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/lib/packwerk.rb b/lib/packwerk.rb
@@ -94,3 +94,7 @@ class ApplicationValidator
     autoload :Helpers
   end
 end
+
+# Required to register the default OffensesFormatter
+# We put this at the *end* of the file to specify all autoloads first
+require "packwerk/formatters/offenses_formatter"
diff --git a/lib/packwerk/offenses_formatter.rb b/lib/packwerk/offenses_formatter.rb
@@ -29,7 +29,6 @@ def included(base)
 
       sig { returns(T::Array[OffensesFormatter]) }
       def all
-        require "packwerk/formatters/offenses_formatter"
         T.unsafe(@offenses_formatters).map(&:new)
       end
 

diff --git a/test/support/offenses_formatter_plain.rb b/test/support/offenses_formatter_plain.rb
@@ -1,8 +1,6 @@
 # typed: strict
 # frozen_string_literal: true
 
-require "packwerk/formatters/offenses_formatter"
-
 module Packwerk
   module Formatters
     class OffensesFormatterPlain < OffensesFormatter